Skip to content

Use signal.CTRL_C_EVENT on windows instead of signal.SIGINT #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use signal.CTRL_C_EVENT on windows instead of signal.SIGINT #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions launch/launch/actions/execute_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,8 @@ def __on_signal_process_event(
return None
if platform.system() == 'Windows' and typed_event.signal_name == 'SIGINT':
# TODO(wjwwood): remove this when/if SIGINT is fixed on Windows
self.__logger.warning(
"'SIGINT' sent to process[{}] not supported on Windows, escalating to 'SIGTERM'"
.format(self.process_details['name']),
)
typed_event = SignalProcess(
signal_number=signal.SIGTERM,
signal_number=signal.CTRL_C_EVENT,
process_matcher=lambda process: True)
self.__logger.info("sending signal '{}' to process[{}]".format(
typed_event.signal_name, self.process_details['name']
Expand Down