-
Notifications
You must be signed in to change notification settings - Fork 158
Allow include: to take a single text element instead of requiring file:
#867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emersonknapp
wants to merge
3
commits into
ros2:rolling
Choose a base branch
from
emersonknapp:emersonknapp/single-element-include
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| launch: | ||
| - executable: | ||
| cmd: ls -l -a -s | ||
| cwd: / | ||
| name: my_ls | ||
| shell: true | ||
| output: log | ||
| emulate_tty: true | ||
| sigkill_timeout: 4.0 | ||
| sigterm_timeout: 7.0 | ||
| launch-prefix: $(env LAUNCH_PREFIX '') | ||
| env: | ||
| - name: var | ||
| value: "1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Copyright 2025 Polymath Robotics, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Test parsing a launch file inclusion.""" | ||
|
|
||
| import io | ||
| from pathlib import Path | ||
| import textwrap | ||
|
|
||
| from launch import LaunchService | ||
| from launch.actions import IncludeLaunchDescription | ||
| from launch.launch_description_sources import AnyLaunchDescriptionSource | ||
|
|
||
| from parser_no_extensions import load_no_extensions | ||
|
|
||
|
|
||
| def test_include(): | ||
| """Parse include yaml example.""" | ||
| path = (Path(__file__).parent / 'executable.yaml').as_posix() | ||
| yaml_file = f"""\ | ||
| launch: | ||
| - include: | ||
| file: {path} | ||
| """ | ||
| yaml_file = textwrap.dedent(yaml_file) | ||
| root_entity, parser = load_no_extensions(io.StringIO(yaml_file)) | ||
| ld = parser.parse_description(root_entity) | ||
| include = ld.entities[0] | ||
| assert isinstance(include, IncludeLaunchDescription) | ||
| assert isinstance(include.launch_description_source, AnyLaunchDescriptionSource) | ||
| ls = LaunchService(debug=True) | ||
| ls.include_launch_description(ld) | ||
| assert 0 == ls.run() | ||
|
|
||
|
|
||
| def test_include_bare_text(): | ||
| """Parse include yaml example.""" | ||
| path = (Path(__file__).parent / 'executable.yaml').as_posix() | ||
| yaml_file = f""" | ||
| launch: | ||
| - include: {path} | ||
christophebedard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| """ | ||
| yaml_file = textwrap.dedent(yaml_file) | ||
| root_entity, parser = load_no_extensions(io.StringIO(yaml_file)) | ||
| ld = parser.parse_description(root_entity) | ||
| include = ld.entities[0] | ||
| assert isinstance(include, IncludeLaunchDescription) | ||
| assert isinstance(include.launch_description_source, AnyLaunchDescriptionSource) | ||
| # No need to run a second time, just testing parsing | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| test_include() | ||
| test_include_bare_text() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we find a more descriptive name for this, or just describe it using words other than "bare text" in the docstring, so that it's a bit clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, a different name is fine, i just wasn't sure what to call it exactly