Skip to content

Commit 1351737

Browse files
ahcordeahcorde
committed
Changelog
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
1 parent 839348c commit 1351737

File tree

4 files changed

+173
-0
lines changed

4 files changed

+173
-0
lines changed

‎rclcpp/CHANGELOG.rst‎

Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,141 @@
22
Changelog for package rclcpp
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
28.0.1 (2024-04-16)
6+
-------------------
7+
* [wjwwood] Updated "Data race fixes" (`#2500 <https://github.com/ros2/rclcpp/issues/2500>`_)
8+
* Fix callback group logic in executor
9+
* fix: Fixed unnecessary copy of wait_set
10+
* fix(executor): Fixed race conditions with rebuild of wait_sets
11+
Before this change, the rebuild of wait set would be triggered
12+
after the wait set was waken up. With bad timing, this could
13+
lead to the rebuild not happening with multi threaded executor.
14+
* fix(Executor): Fixed lost of entities rebuild request
15+
* chore: Added assert for not set callback_group in execute_any_executable
16+
* Add test for cbg getting reset
17+
Co-authored-by: Janosch Machowinski <[email protected]>
18+
* chore: renamed test cases to snake_case
19+
* style
20+
* fixup test to avoid polling and short timeouts
21+
* fix: Use correct notify_waitable\_ instance
22+
* fix(StaticSingleThreadedExecutor): Added missing special case handling for current_notify_waitable\_
23+
* fix(TestCallbackGroup): Fixed test after change to timers
24+
---------
25+
Co-authored-by: Janosch Machowinski <[email protected]>
26+
Co-authored-by: Michael Carroll <[email protected]>
27+
Co-authored-by: Janosch Machowinski <[email protected]>
28+
* fixup var names to snake case (`#2501 <https://github.com/ros2/rclcpp/issues/2501>`_)
29+
* Added optional TimerInfo to timer callback (`#2343 <https://github.com/ros2/rclcpp/issues/2343>`_)
30+
Co-authored-by: Alexis Tsogias <[email protected]>
31+
Co-authored-by: Janosch Machowinski <[email protected]>
32+
* Fix uninitialized memory in test (`#2498 <https://github.com/ros2/rclcpp/issues/2498>`_)
33+
When I added in the tests for large messages, I made a mistake and reserved space in the strings, but didn't actually expand it. Thus, we were writing into uninitialized memory. Fix this by just using the correct constructor for string, which will allocate and initialize the memory properly.
34+
* Ensure waitables handle guard condition retriggering (`#2483 <https://github.com/ros2/rclcpp/issues/2483>`_)
35+
Co-authored-by: Michael Carroll <[email protected]>
36+
* fix: init concatenated_vector with begin() & end() (`#2492 <https://github.com/ros2/rclcpp/issues/2492>`_)
37+
*. this commit will fix the warning [-Wstringop-overflow=] `#2461 <https://github.com/ros2/rclcpp/issues/2461>`_
38+
* Use the same context for the specified node in rclcpp::spin functions (`#2433 <https://github.com/ros2/rclcpp/issues/2433>`_)
39+
* Use the same conext for the specified node in rclcpp::spin_xx functions
40+
* Add test for spinning with non-default-context
41+
* Format code
42+
---------
43+
* Disable compare-function-pointers in test_utilities (`#2489 <https://github.com/ros2/rclcpp/issues/2489>`_)
44+
* address ambiguous auto variable. (`#2481 <https://github.com/ros2/rclcpp/issues/2481>`_)
45+
* Increase the cppcheck timeout to 1200 seconds (`#2484 <https://github.com/ros2/rclcpp/issues/2484>`_)
46+
* Removed test_timers_manager clang warning (`#2479 <https://github.com/ros2/rclcpp/issues/2479>`_)
47+
* Flaky timer test fix (`#2469 <https://github.com/ros2/rclcpp/issues/2469>`_)
48+
* fix(time_source): Fixed possible race condition
49+
* fix(test_executors_time_cancel_behaviour): Fixed multiple race conditions
50+
---------
51+
Co-authored-by: Janosch Machowinski <[email protected]>
52+
* Add tracepoint for generic publisher/subscriber (`#2448 <https://github.com/ros2/rclcpp/issues/2448>`_)
53+
* update rclcpp::Waitable API to use references and const (`#2467 <https://github.com/ros2/rclcpp/issues/2467>`_)
54+
* Utilize rclcpp::WaitSet as part of the executors (`#2142 <https://github.com/ros2/rclcpp/issues/2142>`_)
55+
* Deprecate callback_group call taking context
56+
* Add base executor objects that can be used by implementors
57+
* Template common operations
58+
* Address reviewer feedback:
59+
* Add callback to EntitiesCollector constructor
60+
* Make function to check automatically added callback groups take a list
61+
* Lint
62+
* Address reviewer feedback and fix templates
63+
* Lint and docs
64+
* Make executor own the notify waitable
65+
* Add pending queue to collector, remove from waitable
66+
Also change node's get_guard_condition to return shared_ptr
67+
* Change interrupt guard condition to shared_ptr
68+
Check if guard condition is valid before adding it to the waitable
69+
* Lint and docs
70+
* Utilize rclcpp::WaitSet as part of the executors
71+
* Don't exchange atomic twice
72+
* Fix add_node and add more tests
73+
* Make get_notify_guard_condition follow API tick-tock
74+
* Improve callback group tick-tocking
75+
* Don't lock twice
76+
* Address reviewer feedback
77+
* Add thread safety annotations and make locks consistent
78+
* @wip
79+
* Reset callback groups for multithreaded executor
80+
* Avoid many small function calls when building executables
81+
* Re-trigger guard condition if buffer has data
82+
* Address reviewer feedback
83+
* Trace points
84+
* Remove tracepoints
85+
* Reducing diff
86+
* Reduce diff
87+
* Uncrustify
88+
* Restore tests
89+
* Back to weak_ptr and reduce test time
90+
* reduce diff and lint
91+
* Restore static single threaded tests that weren't working before
92+
* Restore more tests
93+
* Fix multithreaded test
94+
* Fix assert
95+
* Fix constructor test
96+
* Change ready_executables signature back
97+
* Don't enforce removing callback groups before nodes
98+
* Remove the "add_valid_node" API
99+
* Only notify if the trigger condition is valid
100+
* Only trigger if valid and needed
101+
* Fix spin_some/spin_all implementation
102+
* Restore single threaded executor
103+
* Picking ABI-incompatible executor changes
104+
* Add PIMPL
105+
* Additional waitset prune
106+
* Fix bad merge
107+
* Expand test timeout
108+
* Introduce method to clear expired entities from a collection
109+
* Make sure to call remove_expired_entities().
110+
* Prune queued work when callback group is removed
111+
* Prune subscriptions from dynamic storage
112+
* Styles fixes.
113+
* Re-trigger guard conditions
114+
* Condense to just use watiable.take_data
115+
* Lint
116+
* Address reviewer comments (nits)
117+
* Lock mutex when copying
118+
* Refactors to static single threaded based on reviewers
119+
* More small refactoring
120+
* Lint
121+
* Lint
122+
* Add ready executable accessors to WaitResult
123+
* Make use of accessors from wait_set
124+
* Fix tests
125+
* Fix more tests
126+
* Tidy up single threaded executor implementation
127+
* Don't null out timer, rely on call
128+
* change how timers are checked from wait result in executors
129+
* peak -> peek
130+
* fix bug in next_waitable logic
131+
* fix bug in StaticSTE that broke the add callback groups to executor tests
132+
* style
133+
---------
134+
Co-authored-by: Chris Lalancette <[email protected]>
135+
Co-authored-by: William Woodall <[email protected]>
136+
* fix flakiness in TestTimersManager unit-test (`#2468 <https://github.com/ros2/rclcpp/issues/2468>`_)
137+
the previous version of the test was relying on the assumption that a timer with 1ms period gets called at least 6 times if the main thread waits 15ms. this is true most of the times, but it's not guaranteed, especially when running the test on windows CI servers. the new version of the test makes no assumptions on how much time it takes for the timers manager to invoke the timers, but rather focuses on ensuring that they are called the right amount of times, which is what's important for the purpose of the test
138+
* Contributors: Alberto Soragna, Alejandro Hernández Cordero, Chris Lalancette, Homalozoa X, Kotaro Yoshimoto, Michael Carroll, Tomoya Fujita, William Woodall, h-suzuki-isp, jmachowinski
139+
5140
28.0.0 (2024-03-28)
6141
-------------------
7142
* fix spin_some_max_duration unit-test for events-executor (`#2465 <https://github.com/ros2/rclcpp/issues/2465>`_)

‎rclcpp_action/CHANGELOG.rst‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,33 @@ Changelog for package rclcpp_action
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

55

6+
28.0.1 (2024-04-16)
7+
-------------------
8+
* Callback after cancel (`#2281 <https://github.com/ros2/rclcpp/issues/2281>`_)
9+
* feat(Client): Added function to stop callbacks of a goal handle
10+
This function allows us to drop the handle in a locked context.
11+
If we do not do this within a lock, there will be a race condition between
12+
the deletion of the shared_ptr of the handle and the result / feedback
13+
callbacks.
14+
* fix: make Client goal handle recursive
15+
This fixes deadlocks due to release of goal handles in callbacks etc.
16+
* fix(ActionGoalClient): Fixed memory leak for nominal case
17+
This fixes a memory leak due to a self reference in the ClientGoalHandle.
18+
Note, this fix will only work, if the ClientGoalHandle ever receives
19+
a result callback.
20+
* doc: Updated documentation of rclcpp_action::Client::async_send_goal
21+
* docs: Made the async_send_goal documentation more explicit
22+
Co-authored-by: Janosch Machowinski <[email protected]>
23+
* Remake of "fix: Fixed race condition in action server between is_ready and take" (`#2495 <https://github.com/ros2/rclcpp/issues/2495>`_)
24+
Some background information: is_ready, take_data and execute data
25+
may be called from different threads in any order. The code in the old
26+
state expected them to be called in series, without interruption.
27+
This lead to multiple race conditions, as the state of the pimpl objects
28+
was altered by the three functions in a non thread safe way.
29+
Co-authored-by: Janosch Machowinski <[email protected]>
30+
* update rclcpp::Waitable API to use references and const (`#2467 <https://github.com/ros2/rclcpp/issues/2467>`_)
31+
* Contributors: William Woodall, jmachowinski
32+
633
28.0.0 (2024-03-28)
734
-------------------
835
* Do not generate the exception when action service response timeout. (`#2464 <https://github.com/ros2/rclcpp/issues/2464>`_)

‎rclcpp_components/CHANGELOG.rst‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
Changelog for package rclcpp_components
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

5+
28.0.1 (2024-04-16)
6+
-------------------
7+
58
28.0.0 (2024-03-28)
69
-------------------
710
* Add EXECUTOR docs (`#2440 <https://github.com/ros2/rclcpp/issues/2440>`_)

‎rclcpp_lifecycle/CHANGELOG.rst‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@ Changelog for package rclcpp_lifecycle
33
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
44

55

6+
28.0.1 (2024-04-16)
7+
-------------------
8+
* call shutdown in LifecycleNode dtor to avoid leaving the device in un… (`#2450 <https://github.com/ros2/rclcpp/issues/2450>`_)
9+
* call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state.
10+
* add test to verify LifecycleNode::shutdown is called on destructor.
11+
---------
12+
* Contributors: Tomoya Fujita
13+
614
28.0.0 (2024-03-28)
715
-------------------
816
* Update quality declaration documents (`#2427 <https://github.com/ros2/rclcpp/issues/2427>`_)

0 commit comments

Comments
 (0)