Increase test coverage of rclcpp_lifecycle to 96% (#1298)

* Increase test coverage of rclcpp_lifecycle to 96%

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* test_depend

Signed-off-by: Stephen Brawner <[email protected]>

* rcutils test_depend

Signed-off-by: Stephen Brawner <[email protected]>

* More windows warnings

Signed-off-by: Stephen Brawner <[email protected]>

Author: brawner

rclcpp_lifecycle/CMakeLists.txt

@@ -56,16 +56,27 @@ if(BUILD_TESTING)
     ament_target_dependencies(test_lifecycle_node
       "rcl_lifecycle"
       "rclcpp"
+      "rcutils"
     )
-    target_link_libraries(test_lifecycle_node ${PROJECT_NAME})
+    target_link_libraries(test_lifecycle_node ${PROJECT_NAME} mimick)
+  endif()
+  ament_add_gtest(test_lifecycle_publisher test/test_lifecycle_publisher.cpp)
+  if(TARGET test_lifecycle_publisher)
+    ament_target_dependencies(test_lifecycle_publisher
+      "rcl_lifecycle"
+      "rclcpp"
+      "test_msgs"
+    )
+    target_link_libraries(test_lifecycle_publisher ${PROJECT_NAME})
   endif()
   ament_add_gtest(test_lifecycle_service_client test/test_lifecycle_service_client.cpp)
   if(TARGET test_lifecycle_service_client)
     ament_target_dependencies(test_lifecycle_service_client
       "rcl_lifecycle"
       "rclcpp"
+      "rcutils"
     )
-    target_link_libraries(test_lifecycle_service_client ${PROJECT_NAME})
+    target_link_libraries(test_lifecycle_service_client ${PROJECT_NAME} mimick)
   endif()
   ament_add_gtest(test_state_machine_info test/test_state_machine_info.cpp)
   if(TARGET test_state_machine_info)
@@ -104,8 +115,12 @@ if(BUILD_TESTING)
     ament_target_dependencies(test_transition_wrapper
       "rcl_lifecycle"
       "rclcpp"
+      "rcutils"
+    )
+    target_link_libraries(test_transition_wrapper ${PROJECT_NAME} mimick)
+    target_compile_definitions(test_transition_wrapper
+      PUBLIC RCUTILS_ENABLE_FAULT_INJECTION
     )
-    target_link_libraries(test_transition_wrapper ${PROJECT_NAME})
   endif()
 endif()
 

rclcpp_lifecycle/package.xml

@@ -24,6 +24,9 @@
   <test_depend>ament_cmake_gtest</test_depend>
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>ament_lint_common</test_depend>
+  <test_depend>mimick_vendor</test_depend>
+  <test_depend>rcutils</test_depend>
+  <test_depend>test_msgs</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>