Skip to content

Commit 1977397

Browse files
Redundant .c_str() usage in rclcpp_components triggers ament_clang_tidy warning (#2718)
* fix: Simplify string assignment for class name in node_main.cpp.in Signed-off-by: LihanChen2004 <[email protected]> * Remove redundant local variable `name` Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: LihanChen2004 <[email protected]> --------- Signed-off-by: LihanChen2004 <[email protected]> Signed-off-by: LihanChen2004 <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
1 parent 99f1d8d commit 1977397

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

rclcpp_components/src/node_main.cpp.in

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ int main(int argc, char * argv[])
4040
auto loader = new class_loader::ClassLoader(library_name);
4141
auto classes = loader->getAvailableClasses<rclcpp_components::NodeFactory>();
4242
for (const auto & clazz : classes) {
43-
std::string name = clazz.c_str();
44-
if (name.compare(class_name) == 0) {
43+
if (clazz.compare(class_name) == 0) {
4544
RCLCPP_DEBUG(logger, "Instantiate class %s", clazz.c_str());
4645
std::shared_ptr<rclcpp_components::NodeFactory> node_factory = nullptr;
4746
try {

0 commit comments

Comments
 (0)