fixup var names to snake case (#2501)

Signed-off-by: William Woodall <[email protected]>

Author: wjwwood

rclcpp/include/rclcpp/executor.hpp

@@ -487,7 +487,7 @@ class Executor
    */
   RCLCPP_PUBLIC
   static void
-  execute_timer(rclcpp::TimerBase::SharedPtr timer, const std::shared_ptr<void> & dataPtr);
+  execute_timer(rclcpp::TimerBase::SharedPtr timer, const std::shared_ptr<void> & data_ptr);
 
   /// Run service server executable.
   /**

rclcpp/include/rclcpp/timer.hpp

@@ -326,10 +326,10 @@ class GenericTimer : public TimerBase
     >::type * = nullptr
   >
   void
-  execute_callback_delegate(const rcl_timer_call_info_t & timer_call_info_)
+  execute_callback_delegate(const rcl_timer_call_info_t & timer_call_info)
   {
-    const TimerInfo info{Time{timer_call_info_.expected_call_time, clock_->get_clock_type()},
-      Time{timer_call_info_.actual_call_time, clock_->get_clock_type()}};
+    const TimerInfo info{Time{timer_call_info.expected_call_time, clock_->get_clock_type()},
+      Time{timer_call_info.actual_call_time, clock_->get_clock_type()}};
     callback_(info);
   }
 

rclcpp/src/rclcpp/executor.cpp

@@ -547,9 +547,9 @@ Executor::execute_subscription(rclcpp::SubscriptionBase::SharedPtr subscription)
 }
 
 void
-Executor::execute_timer(rclcpp::TimerBase::SharedPtr timer, const std::shared_ptr<void> & dataPtr)
+Executor::execute_timer(rclcpp::TimerBase::SharedPtr timer, const std::shared_ptr<void> & data_ptr)
 {
-  timer->execute_callback(dataPtr);
+  timer->execute_callback(data_ptr);
 }
 
 void