Allow for implicitly convertable loggers as well (#2922)

* Allow for implicitly convertable loggers as well

Signed-off-by: Tim Clephas <[email protected]>

* Test implicitly convertable logger

Signed-off-by: Tim Clephas <[email protected]>

* This can be simplified now

Signed-off-by: Tim Clephas <[email protected]>

* fixup! This can be simplified now

Signed-off-by: Tim Clephas <[email protected]>

---------

Signed-off-by: Tim Clephas <[email protected]>

Author: Timple

rclcpp/include/rclcpp/logging.hpp

@@ -32,9 +32,7 @@
 #define RCLCPP_STATIC_ASSERT_LOGGER(logger) \
   do { \
     static_assert( \
-      ::std::is_same<typename std::remove_cv_t< \
-        typename std::remove_reference_t<decltype(logger)>>, \
-      typename ::rclcpp::Logger>::value, \
+      ::std::is_convertible_v<decltype(logger), ::rclcpp::Logger>, \
       "First argument to logging macros must be an rclcpp::Logger"); \
   } while (0)
 

rclcpp/test/rclcpp/test_logging.cpp

@@ -253,9 +253,19 @@ bool log_function_const_ref(const rclcpp::Logger & logger)
   return true;
 }
 
+class DerivedLogger : public rclcpp::Logger
+{
+public:
+  explicit DerivedLogger(const rclcpp::Logger & logger)
+  : rclcpp::Logger(logger) {}
+};
+
 TEST_F(TestLoggingMacros, test_log_from_node) {
   auto logger = rclcpp::get_logger("test_logging_logger");
   EXPECT_TRUE(log_function(logger));
   EXPECT_TRUE(log_function_const(logger));
   EXPECT_TRUE(log_function_const_ref(logger));
+
+  DerivedLogger derived_logger(logger);
+  RCLCPP_INFO(derived_logger, "successful log from derived logger");
 }