Skip to content

Conversation

@Barry-Xu-2018
Copy link
Contributor

Description

Fixes #1550

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

Copilot AI review requested due to automatic review settings December 3, 2025 03:06
Copilot finished reviewing on behalf of Barry-Xu-2018 December 3, 2025 03:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes parameter parsing for unspecified target nodes (issue #1550) by adding logic to handle the case when target_nodes is not specified or is an empty list. Previously, the function only parsed wildcard parameters when target nodes were not specified, but now it correctly parses all parameters from all node configurations in the YAML file.

Key changes:

  • Added else block in parameter_dict_from_yaml_file() to parse all non-wildcard node parameters when target_nodes is not provided
  • Updated test expectations to verify correct behavior when target_nodes is None or empty
  • Renamed test parameter names for better clarity (e.g., abs-ns-nodenameabs-foo-ns-nodename)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
rclpy/rclpy/parameter.py Adds new else block (lines 426-446) to handle parameter parsing when target_nodes is not specified, collecting parameters from all node configurations except wildcards
rclpy/test/test_parameter.py Updates test expectations and parameter names to validate the new behavior, adding test cases for both wildcard enabled/disabled scenarios when target_nodes is unspecified

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The description and implementation of the function parameter_dict_from_yaml_file() are inconsistent.

1 participant