Skip to content

get valid subscription handle even if cft failed #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: rolling
Choose a base branch
from
Open

get valid subscription handle even if cft failed #106

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09c8533
get valid subscription handle even if cft not supported
Feb 27, 2023
b9e1ec9
Merge remote-tracking branch 'remotes/origin/rolling' into topic-vali…
Mar 1, 2023
7e67759
use a better way to check if cft is enabled
Mar 2, 2023
8e4ebf1
Revert "use a better way to check if cft is enabled"
Mar 2, 2023
5d079a4
make cft expression empty if CFT failed to create
Mar 2, 2023
7f021cd
Merge remote-tracking branch 'remotes/origin/rolling' into topic-vali…
Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions rmw_connextdds_common/src/common/rmw_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,12 +1294,11 @@ RMW_Connext_Subscriber::create(
sub_cft_params,
&cft_topic);

if (RMW_RET_OK != cft_rc) {
if (RMW_RET_UNSUPPORTED != cft_rc) {
return nullptr;
}
} else {
if (RMW_RET_OK == cft_rc) {
sub_topic = cft_topic;
} else {
// RMW_Connext_Subscriber needs this value to check if CFT is enabled or not.
sub_cft_expr = "";
}

// The following initialization generates warnings when built
Expand Down