get valid subscription handle even if cft failed #672
Closed
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2023
MiguelCompany
requested changes
Feb 27, 2023
Collaborator
MiguelCompany
left a comment
MiguelCompany
left a comment
There was a problem hiding this comment.
I suppose this also needs to be changed on rmw_fastrtps_dynamic_cpp
Contributor
Author
|
|
fujitatomoya
approved these changes
Mar 7, 2023
Collaborator
|
@iuhilnehc-ynos can you rebase just in case and start CI for this? |
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
force-pushed
the
topic-valid-handle-even-if-cft-failed
branch
from
7e6d2c3 to
abfed56
Compare
Contributor
Author
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcl need to continue to try rcl cft fallback if rmw implementation failed to call rmw cft.