Skip to content

add : get clients, servers info #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

add : get clients, servers info #771

wants to merge 3 commits into from

Conversation

@leeminju531
Copy link
Contributor

@leeminju531 leeminju531 commented Jun 25, 2024

Add get clients, servers info

Refer to ros2/ros2cli#916

This was referenced Jun 25, 2024
Open
Open
Open
@leeminju531
Copy link
Contributor Author

leeminju531 commented Jun 25, 2024

ref
rmw
rmw_implementation
rmw_fastrtps
rmw_cyclonedds
rmw_connextdds

This was referenced Jun 25, 2024
Open
Open
Open
Open
Open
fujitatomoya
fujitatomoya reviewed Jul 4, 2024
View reviewed changes
@leeminju531 leeminju531 force-pushed the add-clients-servers-info branch from 42f28b6 to a40b0d7 Compare September 27, 2024 14:48
@leeminju531 leeminju531 force-pushed the add-clients-servers-info branch from a40b0d7 to 9ffda3f Compare June 22, 2025 02:27
ahcorde
ahcorde requested changes Jun 23, 2025
View reviewed changes
@ahcorde
Copy link
Contributor

ahcorde commented Jul 21, 2025

Pulls: ros2/rmw#371, ros2/rmw_implementation#238, ros2/rcl#1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_zenoh#679, #771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/ros2cli#916
Gist: https://gist.githubusercontent.com/ahcorde/302c3652a6220b1c87e62745e9f9afff/raw/742f65fffc9bfec58f851df6062324b9d1a85a3c/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rcl rclcpp rclpy ros2cli ros2service
TEST args: --packages-above rmw rmw_implementation rcl rclcpp rclpy ros2cli ros2service
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16548

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Jul 21, 2025
Open
@fujitatomoya fujitatomoya requested a review from ahcorde November 6, 2025 09:55
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Nov 6, 2025

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the add-clients-servers-info branch from 950a7da to 8202d91 Compare November 6, 2025 09:55
fujitatomoya
fujitatomoya reviewed Nov 6, 2025
View reviewed changes
rmw_fastrtps_cpp/src/rmw_get_service_endpoint_info.cpp
@@ -0,0 +1,46 @@
// Copyright 2025 Minju Lee (이민주). All rights reserved.
Copy link
Collaborator

@fujitatomoya fujitatomoya Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can attribute ourselves, but "all right reserved" is extra. see appendix on https://opensource.org/license/apache-2-0

Suggested change
// Copyright 2025 Minju Lee (이민주). All rights reserved.
// Copyright 2025 Minju Lee (이민주).

fujitatomoya
fujitatomoya reviewed Nov 6, 2025
View reviewed changes
rmw_fastrtps_dynamic_cpp/src/rmw_get_service_endpoint_info.cpp
@@ -0,0 +1,46 @@
// Copyright 2025 Minju Lee (이민주). All rights reserved.
Copy link
Collaborator

@fujitatomoya fujitatomoya Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can attribute ourselves, but "all right reserved" is extra. see appendix on https://opensource.org/license/apache-2-0

Suggested change
// Copyright 2025 Minju Lee (이민주). All rights reserved.
// Copyright 2025 Minju Lee (이민주).

fujitatomoya
fujitatomoya reviewed Nov 6, 2025
View reviewed changes
rmw_fastrtps_shared_cpp/src/rmw_get_service_endpoint_info.cpp
@@ -0,0 +1,257 @@
// Copyright 2025 Minju Lee (이민주). All rights reserved.
Copy link
Collaborator

@fujitatomoya fujitatomoya Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can attribute ourselves, but "all right reserved" is extra. see appendix on https://opensource.org/license/apache-2-0

Suggested change
// Copyright 2025 Minju Lee (이민주). All rights reserved.
// Copyright 2025 Minju Lee (이민주).

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

Pulls: ros2/ros2cli#916, ros2/rmw#371, ros2/rmw_implementation#238, #771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/rcl#1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_dds_common#82, ros2/rmw_zenoh#679
Gist: https://gist.githubusercontent.com/fujitatomoya/01385d70469b48f205a68e21219fd395/raw/b02c84fd17938124e2b045dbf016f260e6209ae0/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_sharedcpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
TEST args: --packages-above rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_sharedcpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17407

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2025
Open
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Nov 6, 2025

Pulls: ros2/ros2cli#916, ros2/rmw#371, ros2/rmw_implementation#238, #771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/rcl#1161, ros2/rclcpp#2569, ros2/rclpy#1307, ros2/rmw_dds_common#82, ros2/rmw_zenoh#679
Gist: https://gist.githubusercontent.com/fujitatomoya/3c50929d3b3e884ba6796f6c9f26e92e/raw/b02c84fd17938124e2b045dbf016f260e6209ae0/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
TEST args: --packages-above rmw_zenoh_cpp rmw_dds_common rclpy rclcpp_lifecycle rclcpp rcl rmw_connextdds rmw_connextdds_common rmw_connextddsmicro rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp ros2cli ros2service rmw rmw_implementation test_rmw_implementation
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17408

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs

@sloretz sloretz Awaiting requested review from sloretz

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@fujitatomoya fujitatomoya

Labels

requires-changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leeminju531 @ahcorde @fujitatomoya @cottsay