Skip to content

Catch PackageNotFoundError during default config uri loading to prevent crash #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nibanovic wants to merge 2 commits into
base: rolling
Choose a base branch
from
+15 −5
Open

Catch PackageNotFoundError during default config uri loading to prevent crash #915

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9dae58
catch get_package_share_path() throw on config load
Nibanovic Feb 27, 2026
7e4186e
ament uncrustify
Nibanovic Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions rmw_zenoh_cpp/src/detail/zenoh_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "logging_macros.hpp"

#include <ament_index_cpp/get_package_share_path.hpp>
#include <ament_index_cpp/get_package_prefix.hpp> /* for PackageNotFoundError */
#include <rmw/impl/cpp/macros.hpp>

///=============================================================================
Expand Down Expand Up @@ -119,12 +120,21 @@ std::optional<zenoh::Config> get_z_config(const ConfigurableEntity & entity)
"rmw_zenoh_cpp", "get_z_config called with invalid ConfigurableEntity.");
return std::nullopt;
}
// Get the absolute path to the default configuration file.
std::filesystem::path path_to_config_folder =
ament_index_cpp::get_package_share_path("rmw_zenoh_cpp") / "config";

const std::filesystem::path default_config_path =
path_to_config_folder / envar_map_it->second.second;

std::filesystem::path default_config_path;

try {
// Get the absolute path to the default configuration file.
std::filesystem::path path_to_config_folder =
ament_index_cpp::get_package_share_path("rmw_zenoh_cpp") / "config";

default_config_path = path_to_config_folder / envar_map_it->second.second;
} catch (const ament_index_cpp::PackageNotFoundError& e) {
RMW_ZENOH_LOG_WARN_NAMED(
"rmw_zenoh_cpp",
"Failed to find rmw_zenoh_cpp package in ament_index (%s). "
"Relying on 'ZENOH_*_CONFIG_URI' ENV vars.", e.what());
}

return _get_z_config(envar_map_it->second.first, default_config_path);
}
Expand Down
Loading