Conversation
ahcorde
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rmw_feature_supportedcurrently returnsfalsefor bothRMW_FEATURE_MESSAGE_INFO_PUBLICATION_SEQUENCE_NUMBERandRMW_FEATURE_MESSAGE_INFO_RECEPTION_SEQUENCE_NUMBER, causing rclcpp to skip populating these fields inrclcpp::MessageInfoentirely. Additionally,reception_sequence_numberis always set to 0 with aTODOcomment at both take sites.The fix:
rmw_feature_supportedto returntruefor both sequence number features.std::atomic<uint64_t> reception_sn_counter toSubscriptionData, initialized to 0. Each call totake_one_messageortake_serialized_messageincrements it withfetch_add(1, std::memory_order_relaxed)and assigns the pre-increment value tomessage_info->reception_sequence_number.publication_sequence_numberwas already populated from the attachment; no change needed there.The attachment wire format (
sequence_number | source_timestamp | source_gid) is unchanged — this fix is purely in the subscriber-side bookkeeping.Closes #907
Closes #906
This is an automatic backport of pull request #920 done by [Mergify](https://mergify.com).