Revert "Revert "adding API change for spin_until_complete"" #3334
Conversation
|
This shouldn't be a draft. Its ready to go with the feature merges |
|
@audrow please revert this. (edit, i mean merge this PR, sorry for the confusion.) |
| Rename ``spin_until_future_complete`` to ``spin_until_complete`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| `PR 1874 <https://github.com/ros2/rclcpp/pull/1874>`_ renames ``spin_until_future_complete`` to ``spin_until_complete`` to represent the semantics of being able to spin on values that are not exclusively futures. |
There was a problem hiding this comment.
@SteveMacenski, should we mention ros2/rclcpp#1957 here instead?
Seeing that ros2/rclcpp#1874 was merged is what made me think this was ready to merge.
There was a problem hiding this comment.
I think the "revert revert" language in 1957 makes it less clear to a user. I'd think 1874 is a better link to understand the change, but I don't feel overly strong about it
Now I'm confused -- so you want this merged now @fujitatomoya ? |
|
Oh sorry, i was the one who got confused. |
|
I've opened #4252 to replace this PR. Closing. |
Reverts #3333, which originally reverted #3328.