Skip to content

Conversation

@jacobperron
Copy link
Member

These are placeholders and will be updated during the next development cycle.

@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-445 November 23, 2019 00:07 Inactive
@jacobperron jacobperron self-assigned this Nov 23, 2019
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain the history please duplicate existing files in one commit and then update them in a separate commits (and at the end merge without squashing).

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with @dirk-thomas's comments addressed.

@jacobperron jacobperron force-pushed the jacob/fturtle branch 2 times, most recently from 8159de6 to 6bd4c34 Compare November 23, 2019 00:39
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-445 November 23, 2019 00:39 Inactive
@jacobperron
Copy link
Member Author

Now the commits should be more legible. PTAL.

Signed-off-by: Jacob Perron <[email protected]>
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pending passing CI.

@jacobperron jacobperron merged commit c1d8906 into master Nov 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fturtle branch November 23, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants