Skip to content

add more extra patterns to sentence scanner.#5092

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/more-extra-patterns-sentence-scan
Mar 14, 2025
Merged

add more extra patterns to sentence scanner.#5092
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/more-extra-patterns-sentence-scan

Conversation

@fujitatomoya
Copy link
Collaborator

lesson studied from #5088 and #5089

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Mar 14, 2025
@fujitatomoya
Copy link
Collaborator Author

@DLu @christophebedard can you review this?

@github-actions
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13850564486/artifacts/2750698059.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5092/index.html in your favorite browser

@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Mar 14, 2025
@fujitatomoya fujitatomoya merged commit 82dc620 into rolling Mar 14, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/more-extra-patterns-sentence-scan branch March 14, 2025 21:19
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 82dc620)
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 82dc620)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml
fujitatomoya added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 82dc620)

# Conflicts:
#	.sphinx_tamer.yaml

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@DLu
Copy link
Contributor

DLu commented Mar 16, 2025

Belated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments