Skip to content

Conversation

@christophebedard
Copy link
Member

@christophebedard christophebedard commented Apr 4, 2025

Reverts #998

See #1002. I attempted to fix some issues in #1003, but for now just revert it.

The same change was also reverted in Rolling: #1000

This reverts commit f037c19.

Signed-off-by: Christophe Bedard <[email protected]>
@christophebedard christophebedard force-pushed the revert-998-mjcarroll/backport_2024_42002_fix branch from dd5b35b to a7bc000 Compare April 4, 2025 22:21
@christophebedard
Copy link
Member Author

This reverts the very last commit, and it looks like CI wasn't run when the Rolling PR was reverted (#1000), so I'll just merge this.

@christophebedard christophebedard merged commit 2b92566 into jazzy Apr 4, 2025
2 of 3 checks passed
@christophebedard christophebedard deleted the revert-998-mjcarroll/backport_2024_42002_fix branch April 4, 2025 22:25
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophebedard thanks, one step behind. but i agree with you, this is deeper than it looks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants