Skip to content

Handle find_container_node_names error #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanpauno merged 3 commits into from
Sep 17, 2019
Merged

Handle find_container_node_names error #322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd6cef2
Handle find_container_node_names error
ivanpauno Aug 27, 2019
868530f
Use custom error instead of RuntimeError
ivanpauno Aug 30, 2019
8f8ff71
Update error import
ivanpauno Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ros2component/ros2component/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,10 @@ def find_container_node_names(*, node, node_names):
"""
container_node_names = []
for n in node_names:
services = get_service_info(node=node, remote_node_name=n.full_name)
try:
services = get_service_info(node=node, remote_node_name=n.full_name)
except rclpy.node.NodeNameNonExistentError:
continue
if not any(s.name.endswith('_container/load_node') and
'composition_interfaces/srv/LoadNode' in s.types
for s in services):
Expand Down