-
Notifications
You must be signed in to change notification settings - Fork 297
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
With certain rosbag2_transport::Player constructors, like:
rosbag2/rosbag2_transport/src/rosbag2_transport/player.cpp
Lines 2196 to 2207 in 83b467b
| Player::Player( | |
| std::unique_ptr<rosbag2_cpp::Reader> reader, | |
| std::shared_ptr<KeyboardHandler> keyboard_handler, | |
| const rosbag2_storage::StorageOptions & storage_options, | |
| const rosbag2_transport::PlayOptions & play_options, | |
| const std::string & node_name, | |
| const rclcpp::NodeOptions & node_options) | |
| : rclcpp::Node( | |
| node_name, | |
| rclcpp::NodeOptions(node_options).arguments(play_options.topic_remapping_options)) | |
| { | |
| std::vector<reader_storage_options_pair_t> readers_with_options{}; |
existing
node_options.arguments() are being discarded since they are overridden from the player options arguents. This prevents to set the node namespace, for example.Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working