Skip to content

Add BaseImpl to rosidl_pycommon.interface_base_classes #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add BaseImpl to rosidl_pycommon.interface_base_classes #912

wants to merge 1 commit into from

Conversation

@InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Oct 7, 2025

Description

Expands on #887 by providing a base class for Impl helper and adding another generic argument to BaseAction

Is this user-facing behavior change?

The public facing api should remain the same.

Did you use Generative AI?

Additional Information

@InvincibleRMC
Add BaseImpl
0df7afb 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC InvincibleRMC mentioned this pull request Oct 7, 2025
Open
@kscottz kscottz added the help wanted Extra attention is needed label Oct 16, 2025
@InvincibleRMC
Copy link
Contributor Author

InvincibleRMC commented Nov 6, 2025 •
edited
Loading

@mjcarroll I assume you have just been super busy with ROS CON and that you don't need anything from me.

fujitatomoya
fujitatomoya reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Adding a generic Impl type to BaseAction to improve typing and structure without affecting runtime behavior or APIs.

@mjcarroll
Copy link
Member

mjcarroll commented Nov 7, 2025

Pulls: #912
Gist: https://gist.githubusercontent.com/mjcarroll/d7915640453c60fc4d2c0038b0a27594/raw/5ace04575130991479c72ff0b74480c00664059e/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17417

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@InvincibleRMC
Copy link
Contributor Author

InvincibleRMC commented Nov 8, 2025

@mjcarroll did you build it with ros2/rosidl_python#241 as well?

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Nov 9, 2025

i do not think so, let me rerun the CI with it.

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Nov 9, 2025

Pulls: #912, ros2/rosidl_python#241
Gist: https://gist.githubusercontent.com/fujitatomoya/9f441816f19ee6d405c62125f9726ab5/raw/11c1492eb07fa5b031ba74a1fabf2a2426ca17d9/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_pycommon rosidl_generator_py
TEST args: --packages-above rosidl_pycommon rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17423

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@mjcarroll mjcarroll

Labels

help wanted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@InvincibleRMC @mjcarroll @fujitatomoya @kscottz