Deprecate using set for container based input #243
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
Contributor
Author
|
Cc @christophebedard since we had the discussion in ros2doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed here. This currently doesn't work at all since message are getting re-ordered in flight. Never caught since no unit test was running with a set. I can't imagine anyone is actually using this in production since it just doesn't work. Only a deprecation instead of outright removal is the fact it has existed broken for 9 years.
Also removed the
UserListchecks since isinstance() checks for subclasses andUserListis a subclass ofSequenceso it was never being triggered.Is this user-facing behavior change?
Yes, users cannot pass in sets anymore.
Did you use Generative AI?
Additional Information