Skip to content

add mingw support (check MSVC instead of WIN32 in cmake) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

add mingw support (check MSVC instead of WIN32 in cmake) #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rosidl_typesupport_fastrtps_c/cmake/rosidl_typesupport_fastrtps_c_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ target_link_libraries(${rosidl_generate_interfaces_TARGET}${_target_suffix} PUBL
rosidl_typesupport_fastrtps_cpp::rosidl_typesupport_fastrtps_cpp
rosidl_typesupport_fastrtps_c::rosidl_typesupport_fastrtps_c)

if(NOT WIN32)
if(NOT MSVC AND NOT MSVC_IDE)
set(_target_compile_flags -Wall -Wextra -Wpedantic)
else()
set(_target_compile_flags /W4)
Expand Down
2 changes: 1 addition & 1 deletion ..._typesupport_fastrtps_cpp/cmake/rosidl_typesupport_fastrtps_cpp_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ set_target_properties(${rosidl_generate_interfaces_TARGET}${_target_suffix}
CXX_STANDARD 17)

# Set compiler flags
if(NOT WIN32)
if(NOT MSVC AND NOT MSVC_IDE)
set(_target_compile_flags -Wall -Wextra -Wpedantic -Wredundant-decls)
else()
set(_target_compile_flags /W4)
Expand Down