Skip to content

Fixed crash when raycasting while map is updated #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Fixed crash when raycasting while map is updated #1034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e01a7
Fixed crash when raycasting while map is updated
ahcorde Aug 15, 2023
98e9bfd
Merge remote-tracking branch 'origin/rolling' into ahcorde/map-crash-…
ahcorde May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rviz_default_plugins/src/rviz_default_plugins/displays/map/map_display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ MapDisplay::MapDisplay()
update_profile_(rclcpp::QoS(5)),
update_messages_received_(0)
{
connect(this, SIGNAL(mapUpdated()), this, SLOT(showMap()));
// HACK: Using a direct connection triggers a segfault on NVIDIA hardware (#1793) when rendering
// *and* having performed a depth rendering before (e.g. due to raycasting for selections)
// A queued connection delays the update of renderables after the current
// VisualizationManager::onUpdate() call
connect(this, SIGNAL(mapUpdated()), this, SLOT(showMap()), Qt::QueuedConnection);

update_topic_property_ = new rviz_common::properties::RosTopicProperty(
"Update Topic", "",
Expand Down