Skip to content

Fix to render window flash problem after resizing (in python environment only) #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Fix to render window flash problem after resizing (in python environment only) #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions rviz_rendering/include/rviz_rendering/render_window.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,6 @@ public slots:
// void
// mouseReleaseEvent(QMouseEvent * mouse_event) override;

void
exposeEvent(QExposeEvent * expose_event) override;

bool
event(QEvent * event) override;

Expand Down
16 changes: 1 addition & 15 deletions rviz_rendering/src/rviz_rendering/render_window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ RenderWindow::event(QEvent * event)
{
switch (event->type()) {
case QEvent::Resize:
if (this->isExposed()) {
impl_->resize(this->width(), this->height());
}
impl_->resize(this->width(), this->height());
return QWindow::event(event);
case QEvent::UpdateRequest:
this->renderNow();
Expand All @@ -182,18 +180,6 @@ RenderWindow::event(QEvent * event)
}
}

void
RenderWindow::exposeEvent(QExposeEvent * expose_event)
{
Q_UNUSED(expose_event);

if (this->isExposed()) {
impl_->resize(this->width(), this->height());
this->renderNow();
}
}


void
RenderWindowOgreAdapter::setOgreCamera(RenderWindow * render_window, Ogre::Camera * ogre_camera)
{
Expand Down