Skip to content

Use Qt macro #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Use Qt macro #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0623af9
Use Qt macro: slots -> Q_SLOTS
Masa0u0 Feb 17, 2025
2238e80
Use Qt macro
Masa0u0 Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rviz_common/src/rviz_common/display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ void Display::setFixedFrame(const QString & fixed_frame)

void Display::emitTimeSignal(rclcpp::Time time)
{
emit timeSignal(this, time);
Q_EMIT timeSignal(this, time);
}

void Display::reset()
Expand Down
2 changes: 1 addition & 1 deletion rviz_common/src/rviz_common/frame_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void FrameManager::setFixedFrame(const std::string & frame)
}
if (should_emit) {
// This emission must be kept outside of the mutex lock to avoid deadlocks.
emit fixedFrameChanged();
Q_EMIT fixedFrameChanged();
}
}

Expand Down
2 changes: 1 addition & 1 deletion rviz_common/src/rviz_common/panel_dock_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ void PanelDockWidget::setContentWidget(QWidget * child)
void PanelDockWidget::closeEvent(QCloseEvent * event)
{
Q_UNUSED(event);
emit closed();
Q_EMIT closed();
}

void PanelDockWidget::onChildDestroyed(QObject *) // NOLINT: cpplint thinks this is a cast?
Expand Down
2 changes: 1 addition & 1 deletion rviz_rendering/include/rviz_rendering/render_window.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class RVIZ_RENDERING_PUBLIC RenderWindow : public QWindow
void
windowMovedOrResized();

public slots:
public Q_SLOTS:
virtual
void
renderLater();
Expand Down