Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 29, 2025

Description

  • fix topic handling in Camera display to support images compressed by any supported image_transport
  • make Image and Camera display support images compressed by ffmpeg_image_transport
  • make PointCloud2 display support point clouds compressed by cloudini

Is this user-facing behavior change?

  • users can now select ffmpeg-compressed images in Image and Camera displays
  • users can now select cloudini-compressed point clouds in PointCloud2 displays

Did you use Generative AI?

Yes, GitHub Copilot auto-completion.

Additional Information

Related to #1288?


This is an automatic backport of pull request #1568 done by Mergify.

Co-authored-by: Emre Karincali <[email protected]>
(cherry picked from commit a33b5e9)

# Conflicts:
#	rviz_default_plugins/src/rviz_default_plugins/displays/pointcloud/get_transport_from_topic.cpp
@mergify mergify bot added the conflicts label Aug 29, 2025
Copy link
Contributor Author

mergify bot commented Aug 29, 2025

Cherry-pick of a33b5e9 has failed:

On branch mergify/bp/humble/pr-1568
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit a33b5e94.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rviz_default_plugins/src/rviz_default_plugins/displays/camera/camera_display.cpp
	modified:   rviz_default_plugins/src/rviz_default_plugins/displays/image/get_transport_from_topic.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   rviz_default_plugins/src/rviz_default_plugins/displays/pointcloud/get_transport_from_topic.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Sep 1, 2025

Pulls: #1572
Gist: https://gist.githubusercontent.com/ahcorde/31fd991a6c834a3357996fd391f6a226/raw/56262352fd984017c69bea790c4e252b8edcdd3b/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_default_plugins
TEST args: --packages-above rviz_default_plugins
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16815

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Sep 1, 2025

Pulls: #1572
Gist: https://gist.githubusercontent.com/ahcorde/50706893514784bb4dbf467d81757ab0/raw/56262352fd984017c69bea790c4e252b8edcdd3b/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_default_plugins
TEST args: --packages-above rviz_default_plugins
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16819

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 8b6c336 into humble Sep 1, 2025
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-1568 branch September 1, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants