Skip to content

fix crash(segmentation fault) in propertyHiddenChanged (backport #1587) #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix crash(segmentation fault) in propertyHiddenChanged (backport #1587) #1588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions rviz_common/src/rviz_common/properties/property_tree_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ void PropertyTreeWidget::setModel(PropertyTreeModel * model)
if (model_) {
connect(
model_, SIGNAL(propertyHiddenChanged(const Property*)),
this, SLOT(propertyHiddenChanged(const Property*)), Qt::QueuedConnection);
this, SLOT(propertyHiddenChanged(const Property*)), Qt::DirectConnection);
connect(
model_, SIGNAL(expand(const QModelIndex&)),
this, SLOT(expand(const QModelIndex&)));
Expand All @@ -119,12 +119,14 @@ void PropertyTreeWidget::setModel(PropertyTreeModel * model)
void PropertyTreeWidget::propertyHiddenChanged(const Property * property)
{
if (model_) {
const auto & parent_index = model_->parentIndex(property);
if (parent_index.isValid()) {
setRowHidden(property->rowNumberInParent(), parent_index, property->getHidden());
} else {
printf("Trying to hide property '%s' that is not part of the model.\n",
qPrintable(property->getName()));
if (property->parent() != nullptr) {
const auto & parent_index = model_->parentIndex(property);
if (parent_index.isValid()) {
setRowHidden(property->rowNumberInParent(), parent_index, property->getHidden());
} else {
printf("Trying to hide property '%s' that is not part of the model.\n",
qPrintable(property->getName()));
}
}
}
}
Expand Down