Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 26, 2025

Description

RViz2 crashes with segmentation fault when reloading robot description (can be reproduce with rapidly toggling the RobotModel display on/off). The crash occurs in PropertyTreeWidget::propertyHiddenChanged()

This PR implements a two-part fix:

  1. Change from QueueConnection to DirectConnection as suggested in call propertyHiddenChanged synchronously #1033
  2. Add safety check for Property validity to avoid accessing destroyed object

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information


This is an automatic backport of pull request #1587 done by [Mergify](https://mergify.com).

(cherry picked from commit 9fc8054)

# Conflicts:
#	rviz_common/src/rviz_common/properties/property_tree_widget.cpp
Copy link
Contributor Author

mergify bot commented Sep 26, 2025

Cherry-pick of 9fc8054 has failed:

On branch mergify/bp/humble/pr-1587
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 9fc80543.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rviz_common/src/rviz_common/properties/property_tree_widget.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Sep 26, 2025

Pulls: #1590
Gist: https://gist.githubusercontent.com/ahcorde/c72e9058ec69bc997b9409f1091c881f/raw/a79f403a46e4200378f5588542e8836958d1045d/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_common
TEST args: --packages-above rviz_common
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17061

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde merged commit 8432bf0 into humble Sep 26, 2025
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-1587 branch September 26, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants