Full working update with 1.21.4 (and 3 maybe)#37
Merged
eristhea merged 6 commits intorosebudmods:1.21.3from Mar 23, 2025
Merged
Full working update with 1.21.4 (and 3 maybe)#37eristhea merged 6 commits intorosebudmods:1.21.3from
eristhea merged 6 commits intorosebudmods:1.21.3from
Conversation
Member
|
thank you so much for this! i'll review sometime in the next week :) |
Member
|
thank you again for all this work! i believe i've now fixed every crash in singleplayer and multiplayer and this is ready for release |
eristhea
approved these changes
Mar 22, 2025
This was
linked to
issues
Mar 22, 2025
Closed
Contributor
Author
|
I don't know how I didn't run into any of those issues when testing. Especially the crash. I haven't ran into any other issues. I have another fun little pull ready after this one though, but would rather just get a stable updated version and not include it in this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to work on 1.21.4 without issues, as far as I've seen. Base functions all work at least.
Main changes:
New method for getting and setting colour by UUID as entity data is less available (Probably more ideal for not all colours are rerolled on mode change #32 later)
Updates the Rendering to use the new Render States with the help of an interface to track the Entity UUID
Updates particle for slime as the factory has changed for Render States as well (This was probably the most annoying change)
Updates the Slime splitting (another annoying change)
Fixes Update to 1.21.4 Please #35 :)
Fixes [Crash] net.minecraft.util.crash.CrashException: Saving entity NBT #36 by only using disconnect event for servers and uses server stopped for singleplayer instead (Will need a backport to older versions still)
With the new way they are rendering slimes, the outer layer is rendered separately from the inner layer, this does open up the ability for dual coloured slimes easily (at least I think it's new way of rendering)