Add cancellation token support for the [Gif]SnapshotAsync #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SubVideoAsync methods. Fixes rosenbjerg#592.
snechaev
force-pushed
the
PR-592_Snapshot_Cancellation_Support
branch
from
18d9c75 to
b65714d
Compare
…f an asynchronous operation after the FFmpeg process had already exited. Fixes rosenbjerg#348. Related: rosenbjerg#592
snechaev
force-pushed
the
PR-592_Snapshot_Cancellation_Support
branch
from
b65714d to
f5ecbae
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 69.77% 69.55% -0.22%
==========================================
Files 123 123
Lines 3523 3544 +21
Branches 311 311
==========================================
+ Hits 2458 2465 +7
- Misses 950 964 +14
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rosenbjerg
approved these changes
Oct 27, 2025
Owner
rosenbjerg
left a comment
rosenbjerg
left a comment
There was a problem hiding this comment.
Also looks great, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the following:
Adds cancellation support to
SnapshotAsync,GifSnapshotAsync, andSubVideoAsyncmethods. Fixes Cancellation support for the FFMpeg.SnapshotAsync() and friends #592.Fixes a race condition during cancellation of an asynchronous operation when the FFmpeg process had already exited. Fixes randomly errors, "The process instance has already exited" #348.