Skip to content

Conversation

@pcf0
Copy link

@pcf0 pcf0 commented Nov 2, 2025

This PR includes also #603.

I have added a number of arguments that I use in my project via extensions.
The namespaces are structured according to the ffmpeg documentation, because in my opinion the parameters of FFmpeg and their interaction are already very complex and confusing.
That helped me to understand them.
I have therefore also added (currently unnecessary) marker interfaces such as IMuxerArgument and IDemuxerArgument.

I hope that this will also be helpful for this project.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 98.32402% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.10%. Comparing base (1c4333e) to head (994121c).
⚠️ Report is 195 commits behind head on main.

Files with missing lines Patch % Lines
...ideoFilters/Vaapi/VideoFilterScaleVaapiArgument.cs 81.81% 0 Missing and 2 partials ⚠️
FFMpegCore/FFMpeg/Arguments/BaseBoolArgument.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   71.20%   73.10%   +1.89%     
==========================================
  Files         117      148      +31     
  Lines        2973     3722     +749     
  Branches      284      315      +31     
==========================================
+ Hits         2117     2721     +604     
- Misses        751      884     +133     
- Partials      105      117      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tqk2811
Copy link

tqk2811 commented Nov 20, 2025

There is no particular reason these videofilter arguments are not more directly supported, other than the fact that this library does not aim to support all ffmpeg arguments directly as that would too complex for a wrapper library. Instead, the aim is to support commonly used arguments and then support the remaining indirectly but still conveniently, i.e. through WithCustomArgument

#588 (comment)

I think u can write your own library with extension.
If you want a complex filter and argument system you can look at https://github.com/tqk2811/FFmpegArgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants