Skip to content

Conversation

@ememadegbola
Copy link

Added overloads to the FFProbe.GetFrames and FFProbe.GetFramesAsync methods to allow passing in Stream objects

  • Also refactored the FFProbe Analyse and GetFrames methods to all share the same backing logic and reduce code duplication

Testing Enhancements:

  • Added new tests FrameAnalysis_FromStream_Sync and FrameAnalysis_FromStream_Async to verify frame extraction from a Stream source, both synchronously and asynchronously. [1] [2]

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.89%. Comparing base (5356536) to head (b238e45).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
FFMpegCore/FFProbe/FFProbe.cs 84.61% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   71.72%   71.89%   +0.16%     
==========================================
  Files         123      123              
  Lines        3544     3526      -18     
  Branches      311      304       -7     
==========================================
- Hits         2542     2535       -7     
+ Misses        888      876      -12     
- Partials      114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Reordered public methods so Analyse, GetFrames and GetPackets (and their overloads) are grouped together for readability
- Updated synchronous overloads to call the corresponding async implementations and wait with ConfigureAwait(false).GetAwaiter().GetResult() to avoid duplicated logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants