Skip to content

Conversation

@RudyTheDev
Copy link

I noticed that .DisableChannel(Channel.Subtitle) and .DisableChannel(Channel.Data) don't actually do anything even though ffmpeg has the corresponding -sn and -dn options. This PR adds these two. It also catches all the other enum's cases so this doesn't just silently fail if the user does something that is not allowed or supported.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.89%. Comparing base (5356536) to head (fc78b6e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   71.72%   71.89%   +0.17%     
==========================================
  Files         123      123              
  Lines        3544     3555      +11     
  Branches      311      314       +3     
==========================================
+ Hits         2542     2556      +14     
+ Misses        888      886       -2     
+ Partials      114      113       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants