break out files common to both firmware and board modules.#447
Closed
break out files common to both firmware and board modules.#447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several files (in particular board.h) in the varmint_h7/test directory are copies of what is in the main rosflight include directory. I separated the common include files into their own module to avoid this duplication.
You still have to make sure you are using consistent branches.
rosflight_firmware <-- varmint_h7 <-- rosflight_interface*
and
rosflight_firmware <-- rosflight_interface**
note that * and ** exist in different locations in the project tree and need to be at the same branch/commit level, so I think the order of updates/commit/push is
rosflight_interface*
rosflight_interface**
varmint_h7
rosflight_firmware
Things would be a lot easier if varmint_h7 and rosflight_interface were just part of rosflight_firmware and not submodules.