Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In base rosflight_firmware:
+Moved GNSS data type conversion from mavlink into board
+Removed ublox gnss fix type
+Removed unused variables in rosflight_structs.h associated with unused ublox packets.
+Updated parameters_test.cpp to match param.cpp
+Removed cases in void Mixer::param_change_callback(uint16_t param_id) that don't require action and were causing undesired recursion.
In boards/varmint_h7:
+Created DoubleBuffer interface
+Replaced PacketFifo with DoubleBuffer for sensors since it's more efficient and we only ever used the most recent value read for sensors. Also removed associated, and now unused, #defines in BoardConfig.h's
+Added type conversion for GNSS data to match new rosflight_structs.h
+Removed .clang-format from boards/varmint_h7 (did not run formatter to avoid spurious changes during review)
+Pass header structure into misc_header().
+Added MiscRotatable to misc.h. Used to align sensor with each other and the board axes.
+Removed external SPI in Pixracer Pro version. Replace with 3 GPIO probe outputs and One EXTI input for GPS PPS
Cleanup:
+Replaced build_varmint.sh with unit_test.sh
+Added CMakeFiles to .gitignore
+Added CMakeCache.txt to .gitignore
+Moved read_complete in rosflight_structs.h structures into the header structure as "complete"
+Removed some unused and commented-out code
Todo: