Merged
Conversation
JMoore5353
force-pushed
the
ptt/mixer_mod
branch
from
d6ea337 to
ef9789b
Compare
JMoore5353
approved these changes
Aug 4, 2025
Contributor
There was a problem hiding this comment.
Looks good. I merged in #456 before this, so I rebased onto main and fixed a typo in a var name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
void Mixer::param_change_callback(uint16_t param_id) updates all the mixer values when only one needs to be updated. This pull request is intended to speed up the code and reduce unnecessary actions.