Skip to content

Jacob/extend command vector#244

Merged
JMoore5353 merged 3 commits intomainfrom
jacob/extend-command-vector
Jan 27, 2026
Merged

Jacob/extend command vector#244
JMoore5353 merged 3 commits intomainfrom
jacob/extend-command-vector

Conversation

@JMoore5353
Copy link
Contributor

This PR

  1. Implements the changes from this PR dealing with the changes to the command vector.
  2. Moves the logic that prints the mixing matrix to the screen from the forces and moments interface node to rosflight_io. Since this is a very useful debugging tool, I thought this would be good to do. It only prints once on startup.
  3. Adds a service to rosflight_io to print the mixing matrix on demand.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements changes to support an extended command vector in ROSflight, updating the system from a 6-element to a 10-element command structure. It also relocates mixing matrix debugging output from the simulation node to rosflight_io for better accessibility.

Changes:

  • Extended command vector from 6 to 10 elements across the firmware interface and message definitions
  • Moved mixing matrix logging from forces_and_moments_interface to rosflight_io with on-demand printing capability
  • Updated firmware submodule to align with the new command structure

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rosflight_msgs/msg/Command.msg Replaced 6 individual command fields (qx, qy, qz, fx, fy, fz) with a 10-element array and extended ignore bitmasks to support all 10 values
rosflight_sim/src/forces_and_moments_interface.cpp Changed mixing matrices from 6xN to NxN (10x10), updated loop bounds, and removed local logging of mixing matrices
rosflight_sim/include/rosflight_sim/forces_and_moments_interface.hpp Updated mixing matrix type declarations to be square 10x10 matrices
rosflight_io/src/rosflight_io.cpp Added log_mixer_params() function, printMixingMatrixCallback service, and integrated mixing matrix logging on startup
rosflight_io/include/rosflight_io/rosflight_io.hpp Added declarations for new mixing matrix logging function and service callback
rosflight_firmware Updated submodule reference to version supporting extended command vector

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JMoore5353 JMoore5353 requested a review from Copilot January 27, 2026 04:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rosflight rosflight deleted a comment from iandareid Jan 27, 2026
@JMoore5353 JMoore5353 force-pushed the jacob/extend-command-vector branch from 56665ae to 1e0b3f1 Compare January 27, 2026 19:19
@JMoore5353 JMoore5353 merged commit 9cfc773 into main Jan 27, 2026
0 of 2 checks passed
@JMoore5353 JMoore5353 deleted the jacob/extend-command-vector branch January 27, 2026 19:33
@JMoore5353 JMoore5353 restored the jacob/extend-command-vector branch January 31, 2026 03:42
@JMoore5353 JMoore5353 deleted the jacob/extend-command-vector branch January 31, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants