Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements changes to support an extended command vector in ROSflight, updating the system from a 6-element to a 10-element command structure. It also relocates mixing matrix debugging output from the simulation node to rosflight_io for better accessibility.
Changes:
- Extended command vector from 6 to 10 elements across the firmware interface and message definitions
- Moved mixing matrix logging from forces_and_moments_interface to rosflight_io with on-demand printing capability
- Updated firmware submodule to align with the new command structure
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rosflight_msgs/msg/Command.msg | Replaced 6 individual command fields (qx, qy, qz, fx, fy, fz) with a 10-element array and extended ignore bitmasks to support all 10 values |
| rosflight_sim/src/forces_and_moments_interface.cpp | Changed mixing matrices from 6xN to NxN (10x10), updated loop bounds, and removed local logging of mixing matrices |
| rosflight_sim/include/rosflight_sim/forces_and_moments_interface.hpp | Updated mixing matrix type declarations to be square 10x10 matrices |
| rosflight_io/src/rosflight_io.cpp | Added log_mixer_params() function, printMixingMatrixCallback service, and integrated mixing matrix logging on startup |
| rosflight_io/include/rosflight_io/rosflight_io.hpp | Added declarations for new mixing matrix logging function and service callback |
| rosflight_firmware | Updated submodule reference to version supporting extended command vector |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iandareid
approved these changes
Jan 27, 2026
56665ae to
1e0b3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
rosflight_io. Since this is a very useful debugging tool, I thought this would be good to do. It only prints once on startup.rosflight_ioto print the mixing matrix on demand.