Sync with upstream rossjrw/pr-preview-action (84 commits)#133
Closed
npwolf wants to merge 9 commits intorossjrw:mainfrom
Closed
Sync with upstream rossjrw/pr-preview-action (84 commits)#133npwolf wants to merge 9 commits intorossjrw:mainfrom
npwolf wants to merge 9 commits intorossjrw:mainfrom
Conversation
* allow custom comment headers * allow custom comment text * fix default
Sync with 84 upstream commits. Resolves conflict in action.yml by taking upstream's restructured architecture and re-applying our customizations (ssh-key, custom-header, custom-message-suffix). Updates generate-comment.sh to support custom-message-suffix parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Opened against upstream by mistake, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges 84 commits from upstream rossjrw/pr-preview-action into our fork, bringing us up to date with all upstream improvements.
Upstream features gained
action.ymlintolib/main.sh,lib/generate-comment.sh, etc.action.ymlis completely restructuredwait-for-pages-deployment— Wait for Pages build before posting commentcommenttoggle — Ability to disable sticky commentdeploy-commit-message/remove-commit-messageinputsgit-config-name/git-config-emailpages-base-url/pages-base-path— Replaces deprecatedcustom-urlcustom-urlpr-numberinput — Override PR numberdeployment-action,pages-base-url,preview-url, etc.github-pages-deploy-actionfrom v4.5.0 to v4.7.4sticky-pull-request-commentfrom v2.9.0 to v2.9.2GITHUB_API_URLvariable — Uses env var instead of hardcoded URLConflict resolution
Only
action.ymlhad conflicts. Resolved by taking upstream's restructured version and re-applying our fork's customizations:ssh-keyinput — re-added and passed through to both deploy and remove stepscustom-headerinput — re-added and used as theheaderfor sticky PR comments (both deploy and remove)custom-message-suffixinput — re-added and passed as a new 10th argument tolib/generate-comment.sh, which was updated to render it in the deploy commentFiles changed
action.yml— Conflict resolved with our customizations preserved on upstream's new structurelib/generate-comment.sh— Addedcustom_message_suffix(10th param) support for deploy commentsTest plan
ssh-keypassthrough works for SSH-based deploymentscustom-headersets the sticky comment header correctlycustom-message-suffixappends text to the deploy comment🤖 Generated with Claude Code