Add ssh-key input for SSH-based deployments#134
Closed
npwolf wants to merge 1 commit intorossjrw:mainfrom
Closed
Conversation
Pass through an `ssh-key` input to JamesIves/github-pages-deploy-action for both deploy and remove steps. This allows users to authenticate via a deploy key instead of a token, which is useful for cross-repository deployments or environments where SSH is preferred. The input is optional and is a no-op when not provided, preserving existing behavior.
Owner
|
Seems like a fair feature request, was the PR closure / branch deletion intentional? |
Author
Yeah, this worked previously, but after syncing our fork it broke and I decided to just move to a github app. |
Owner
|
Interesting - I can't imagine why that would have been affected at all. Would be happy to help you figure it out if you're able to share more info / workflow logs, but if you've already figured out a different solution then no worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passes through an
ssh-keyinput toJamesIves/github-pages-deploy-actionfor both deploy and remove steps. This allows users to authenticate via a deploy key instead of a token, which is useful for cross-repository deployments or environments where SSH is preferred.The input is optional and is a no-op when not provided, preserving existing behavior.
Changes
ssh-keyinput toaction.ymlssh-keyto both the deploy and remove invocations ofgithub-pages-deploy-actionContext
We've been maintaining this as a fork addition at datagrail/pr-preview-action and would like to contribute it upstream so we can stop carrying the patch.