feat: Add SOCKS5 proxy support #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git2_curl seems only automatically get the proxy url from http_proxy/https_proxy environment variables add a manual url fetch from the config file
git2_curl exposes more specific error message than vanilla git2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #133.
Adds SOCKS5 proxy support (
socks5://andsocks5h://) by switching to thegit2-curlbackend forgit2, following the solution established by Cargo to work around git2's proxy limitations (See rust-lang/cargo#636).This approach replaces git2's default HTTP transport with libcurl, which properly handles SOCKS5 proxies. And also as a side effect, sheldon now respects
http_proxy,https_proxyandall_proxyenv vars. Previously, it will just ignore proxy if there's no proxy setting in .gitconfig