This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Handle case where fees are not computed at charge time#17
Open
FMCorz wants to merge 1 commit intorossp:masterfrom
Open
Handle case where fees are not computed at charge time#17FMCorz wants to merge 1 commit intorossp:masterfrom
FMCorz wants to merge 1 commit intorossp:masterfrom
Conversation
Owner
|
At face value this looks fine to me, however I'm not in a position to be able to test it at the moment. Are there any other users who can put their hand up and do a quick test of this prior to merge? |
Author
|
Note that this patch has been used in production since then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When charging in a currency that is not the settlement currency, the fees are not computed at the time of the charge. My tests were done using USD and settling in AUD.
This does not appear in Pin's documentation, so I reached out to them to confirm:
The patch deals with this situation.
Sample request: