Skip to content

feat: enable additional lint rules for better code quality#78

Merged
kelsos merged 5 commits intorotki:mainfrom
kelsos:feat/rules
Feb 16, 2026
Merged

feat: enable additional lint rules for better code quality#78
kelsos merged 5 commits intorotki:mainfrom
kelsos:feat/rules

Conversation

@kelsos
Copy link
Member

@kelsos kelsos commented Feb 16, 2026

Summary

  • Enable no-nested-ternary as error for JavaScript
  • Add 9 vitest rules for better test quality (max-nested-describe, no-conditional-in-test, no-duplicate-hooks, prefer-hooks-on-top, prefer-mock-promise-shorthand, prefer-to-be, prefer-to-contain, prefer-to-have-length, require-top-level-describe)
  • Enable unicorn/no-unused-properties and unicorn/consistent-destructuring as warnings
  • Enable vue/no-unused-properties as warning for props, data, computed, and methods
  • Update Node.js version requirement in README to match package.json (>=24 <25)

Test plan

  • All 16 tests pass (6 snapshot + 10 fixture)
  • Snapshots updated
  • Lint-staged passes on all commits

@kelsos kelsos requested a review from a team as a code owner February 16, 2026 16:28
Errors when ternary expressions are nested inside other ternaries,
encouraging more readable conditional logic. No autofix.
Adds max-nested-describe, no-conditional-in-test, no-duplicate-hooks,
prefer-hooks-on-top, prefer-mock-promise-shorthand, prefer-to-be,
prefer-to-contain, prefer-to-have-length, and require-top-level-describe.
…ng as warnings

Warns on unused object properties and inconsistent use of destructured
variables to encourage cleaner code patterns.
Warns on unused props, data, computed, and methods in Vue components
to help catch dead code.
Aligns README with package.json engines requirement (>=24 <25).
@kelsos kelsos merged commit 52e5a86 into rotki:main Feb 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant