feat: add new rotki plugin rules and fix type errors#79
Merged
kelsos merged 4 commits intorotki:mainfrom Feb 23, 2026
Merged
Conversation
BREAKING CHANGE: `as` type assertions are now forbidden. Use type guards, generics, or `satisfies` instead.
kelsos
force-pushed
the
feat/new-rules
branch
from
49090ea to
bc6af9a
Compare
BREAKING CHANGE: `else` and `else if` blocks are now disallowed. Use early returns or ternary operators instead.
Bump @rotki/eslint-plugin peer dependency to >=1.3.0 and enable new composable rules (strict as warn, stylistic gated by stylistic option). Replace @intlify/vue-i18n/no-unused-keys with the faster @rotki/no-unused-i18n-keys rule, always enabled by default.
Make mergePrettierOptions generic to preserve parser type from overrides. Normalize StylisticConfig indent to handle array form of IndentRuleOptions.
kelsos
force-pushed
the
feat/new-rules
branch
from
bc6af9a to
3aac6af
Compare
kelsos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rotki/eslint-pluginpeer dependency to>=1.3.0warn, stylistic rules gated bystylisticoption)@intlify/vue-i18n/no-unused-keyswith the 14x faster@rotki/no-unused-i18n-keys, always enabled by defaultformatters.ts,jsonc.ts, andyaml.ts(genericmergePrettierOptions, normalizeIndentRuleOptionsarray form)Test plan
pnpm run buildpassespnpm run typecheckpasses (0 errors, previously had 4)pnpm run lintpasses (0 errors, only pre-existing complexity warnings)pnpm run testpasses (16/16)