Skip to content

Force to update CurrentIndex before scroll ended (during scroll) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ems107 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Force to update CurrentIndex before scroll ended (during scroll) #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cac7f12
Force to update CurrentIndex before scroll ended (during scroll)
ems107 Oct 8, 2022
252e097
pr changes
ems107 Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...o.CollectionView.Droid/Renderers/CollectionViewRenderer.OnControlScrollChangedListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ public override void OnScrolled(RecyclerView recyclerView, int dx, int dy)

_currentOffset += dx;

if (_element.ForceToUpdateCurrentIndexDuringScroll && _weakNativeView.TryGetTarget(out CollectionViewRenderer nativeView))
{
_cts?.Cancel();
_cts = new CancellationTokenSource();
UpdateCurrentIndex(nativeView, _cts.Token);
}

var infiniteListLoader = _element?.InfiniteListLoader;
if (infiniteListLoader == null)
{
Expand Down
12 changes: 12 additions & 0 deletions Sharpnado.CollectionView/RenderedViews/CollectionView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ public class CollectionView : View
typeof(CollectionView),
1);

public static readonly BindableProperty ForceToUpdateCurrentIndexDuringScrollProperty = BindableProperty.Create(
Copy link
Owner

@roubachof roubachof Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ForceUpdateCurrentIndexDuringScroll is a better name

Copy link
Author

@ems107 ems107 Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

nameof(ForceToUpdateCurrentIndexDuringScroll),
typeof(bool),
typeof(CollectionView),
false);

public CollectionView()
{
// default layout is VerticalList
Expand Down Expand Up @@ -365,6 +371,12 @@ public int ColumnCount
set => SetValue(ColumnCountProperty, value);
}

public bool ForceToUpdateCurrentIndexDuringScroll
{
get => (bool)GetValue(ForceToUpdateCurrentIndexDuringScrollProperty);
set => SetValue(ForceToUpdateCurrentIndexDuringScrollProperty, value);
}

public Func<ViewCell, Task> PreRevealAnimationAsync { get; set; }

public Func<ViewCell, Task> RevealAnimationAsync { get; set; }
Expand Down