Conversation
Do not rely/fall-back to the default name.
Do not rely/fall-back to the default name.
Collaborator
Author
|
Idaelly this is updating the appengine bits so it'll be more clear (to me, and internal systems) what/where/how the historical-roa bits connect / etc. we're attempting to move this from my personal bits over to the corp managed appengine world, ideally also putting the data in the same space as the routing data. |
Collaborator
Author
|
also, update the goruntime to something current. :) |
hanskuhn
approved these changes
May 4, 2025
Member
hanskuhn
left a comment
hanskuhn
left a comment
There was a problem hiding this comment.
OK to merge! Thanks for doing this, Chris. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falling back to the default app engine service name is uncool.