Skip to content

fix duplicated attribution as well as disabled setAttributionFromService #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix duplicated attribution as well as disabled setAttributionFromService #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,11 +437,11 @@ export default class FeatureService {

const attributionController = this._map._controls.find(c => '_attribHTML' in c)

if (!attributionController) return
if (!attributionController || !this._esriServiceOptions.setAttributionFromService) return

const customAttribution = attributionController.options.customAttribution

if (typeof customAttribution === 'string') {
if (typeof customAttribution === 'string' && !customAttribution.includes(POWERED_BY_ESRI_ATTRIBUTION_STRING)) {
attributionController.options.customAttribution = `${customAttribution} | ${POWERED_BY_ESRI_ATTRIBUTION_STRING}`
} else if (customAttribution === undefined) {
attributionController.options.customAttribution = POWERED_BY_ESRI_ATTRIBUTION_STRING
Expand Down