Fix old macos version build issue #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to build the plugin on my mac, which is on 15.3.2, the reason for this was that OBS didn't build, probably because the developer tools being too new, which messed up some of the CMake SDK selection.
I noticed this got fixed upstream just a few weeks ago in obsproject/obs-studio@8f1bcc1, this is why I bumped the obs-studio dependency to install from a recent commit.
On that recent commit it looks like the CMake arg
ENABLE_UIgot renamed toENABLE_FRONTEND, and the functionobs_scene_sceneitem_from_sourcegot deprecated, which I found an alternative for