Change expected output of the clean command to also work for dnf5daemon#1662
Merged
kontura merged 1 commit intorpm-software-management:mainfrom Apr 7, 2025
Merged
Conversation
Contributor
Author
|
I just thought of another possibility for the output checking - to introduce a separate steps to check dnf5 output vs. dnf5daemon output. This might come in handy if there are more differences like this one. I will look into it, marking it as draft for now. |
This was referenced Apr 4, 2025
Contributor
Author
|
I added steps to check specifically dnf5 and dnf5daemon outputs. |
kontura
reviewed
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output for the daemon is different from dnf5. I think that duplicating the tests to customize them for each command is not necessary when the only difference is this output.