Fix libsolv nightly builds by downloading all current patches#1835
Merged
kontura merged 1 commit intorpm-software-management:mainfrom Feb 24, 2026
Merged
Fix libsolv nightly builds by downloading all current patches#1835kontura merged 1 commit intorpm-software-management:mainfrom
kontura merged 1 commit intorpm-software-management:mainfrom
Conversation
mfocko
reviewed
Feb 24, 2026
.github/workflows/nightly.yml
Outdated
| # Download spec | ||
| - "wget https://src.fedoraproject.org/rpms/libsolv/raw/main/f/libsolv.spec -O libsolv.spec" | ||
| # Download patches used in the spec | ||
| - bash -c "spectool -P libsolv.spec | awk '{print $2}' | xargs -I {} curl -O https://src.fedoraproject.org/rpms/libsolv/raw/rawhide/f/{}" |
Contributor
There was a problem hiding this comment.
I would probably add:
Suggested change
| - bash -c "spectool -P libsolv.spec | awk '{print $2}' | xargs -I {} curl -O https://src.fedoraproject.org/rpms/libsolv/raw/rawhide/f/{}" | |
| - bash -c "spectool -P libsolv.spec | awk '{print $2}' | xargs -I {} curl --retry 3 -O https://src.fedoraproject.org/rpms/libsolv/raw/rawhide/f/{}" |
I'm actually surprised that the downloading of specfile has not been an issue so far. However downloading patches in a succession will probably trip up Pagure…
I hope I get to live to see the day Pagure dies…
Since we take libsolv specfile from fedora we have to somehow deal with its patches otherwise the build fails. We could either drop them or use them. Since the specfile could be changed in a way that requires the patches to successfully create an rpm I think it will be more robust to download and use them.
kontura
force-pushed
the
fix-nightly-libsolv
branch
from
1751f17 to
82d3cba
Compare
mfocko
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we take libsolv specfile from fedora we have to somehow deal with its patches otherwise the build fails.
(It currently fails due to a patch that is not found: https://github.com/rpm-software-management/ci-dnf-stack/actions/runs/22333046695/job/64619445104)
We could either drop them or use them.
Since the specfile could be changed in a way that requires the patches to successfully create an rpm I think it will be more robust to download and use them.