Skip to content

Disallow dnf download non-sense without --skip-unavailable#2174

Merged
ppisar merged 1 commit intorpm-software-management:mainfrom
alimirjamali:issue-1151-download-of-unavailable
Apr 3, 2025
Merged

Disallow dnf download non-sense without --skip-unavailable#2174
ppisar merged 1 commit intorpm-software-management:mainfrom
alimirjamali:issue-1151-download-of-unavailable

Conversation

@alimirjamali
Copy link
Copy Markdown
Contributor

@alimirjamali alimirjamali commented Apr 2, 2025

resolves: #1151

@alimirjamali alimirjamali requested a review from a team as a code owner April 2, 2025 17:33
@alimirjamali alimirjamali requested review from ppisar and removed request for a team April 2, 2025 17:33
ppisar
ppisar reviewed Apr 3, 2025
View reviewed changes
@ppisar ppisar self-assigned this Apr 3, 2025
@alimirjamali alimirjamali force-pushed the issue-1151-download-of-unavailable branch from ae2a25b to 56c400c Compare April 3, 2025 11:26
@alimirjamali alimirjamali force-pushed the issue-1151-download-of-unavailable branch from 56c400c to 18cb827 Compare April 3, 2025 12:09
ppisar
ppisar approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good.

I believe the CI failure (group install) is unrelated. Though I will try to locate the breaking commit before merging this change.

@alimirjamali
Copy link
Copy Markdown
Contributor Author

alimirjamali commented Apr 3, 2025

I believe the CI failure (group install) is unrelated. Though I will try to locate the breaking commit before merging this change.

The 1st set of errors (dnf clean test failures) are introduced by this PR? (cc. @m-blaha):

rpm-software-management/ci-dnf-stack#1660

@m-blaha
Copy link
Copy Markdown
Member

m-blaha commented Apr 3, 2025

I believe the CI failure (group install) is unrelated. Though I will try to locate the breaking commit before merging this change.

The 1st set of errors (dnf clean test failures) are introduced by this PR? (cc. @m-blaha):

rpm-software-management/ci-dnf-stack#1660

Actually, it should be fixed by this PR.

@alimirjamali
Copy link
Copy Markdown
Contributor Author

alimirjamali commented Apr 3, 2025

Actually, it should be fixed by this PR.

Maybe not. When I look at the test results, the output is from this (dnf5daemon-client/commands/clean rather than dnf5/commands/clean):
https://github.com/rpm-software-management/dnf5/blob/main/dnf5daemon-client/commands/clean/clean.cpp#L85-L89

So the dnf5daemon-client/command/clean output is unrelated to #817

@ppisar
Copy link
Copy Markdown
Contributor

ppisar commented Apr 3, 2025 •
edited
Loading

The dnf/comps-group-list.feature tests fail for dnf5daemon-client because dnf5daemon-client does not implement them (issue #2176). The failure is unrelated to this pull request.

@ppisar ppisar added this pull request to the merge queue Apr 3, 2025
Merged via the queue into rpm-software-management:main with commit ba0e0df Apr 3, 2025
17 of 21 checks passed
@alimirjamali alimirjamali deleted the issue-1151-download-of-unavailable branch April 3, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-blaha m-blaha m-blaha left review comments

@ppisar ppisar ppisar approved these changes

Assignees

@ppisar ppisar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dnf5 download exits successfully with a bad argument

3 participants

@alimirjamali @m-blaha @ppisar